Words & Music: Larry Shay, Mark Fisher, & Joe Goodwin (1928)


When you’re smiling,
When you’re smiling,
The whole world smiles with you.
When you’re laughing,
When you’re laughing,
The sun comes shining through.

But when you’re are crying,
You bring on the rain,
So stop your sighing –
Be happy again!
So keep on smiling
`Cause when you’re smiling,
The whole world smiles with you.


“When You’re Smiling” is a song made famous by Louis Armstrong, who recorded it at least three times, in 1929, 1932, and 1956. Many other versions exist, including Dean Martin’s parody version “When You’re Drinkin'”!


A delightful version by Dean Martin:

This a great version, though it’s not a patch on this version by our student with disabilities Michael Brenner (I admit we’re biased!):

And here is the Sing-A-long version for listening to and downloading:

When You're Smiling